migrate pyqt5 to pyside6

apps/studio/tests/test_scene3d_view.py

@@ -29,8 +29,8 @@ import numpy as np
 import pytest
 
 import ui_check
-from PyQt5.QtCore import pyqtSignal
-from PyQt5.QtWidgets import QWidget
+from PySide6.QtCore import Signal
+from PySide6.QtWidgets import QWidget
 from orisys_app_shared.i18n import t
 from orisys_app_shared.scene3d import synthetic
 from orisys_app_shared.scene3d.contracts import (
@@ -276,8 +276,8 @@ class _RecordingView(QWidget):
     a real ``QWidget`` because the container puts it in its stack.
     """
 
-    diagnosticRaised = pyqtSignal(object)
-    enabledChanged = pyqtSignal(bool)
+    diagnosticRaised = Signal(object)
+    enabledChanged = Signal(bool)
 
     def __init__(self, parent=None) -> None:
         super().__init__(parent)
@@ -559,7 +559,9 @@ def test_a_package_is_loaded_off_the_gui_thread(qt_app, write_poc):
     loaded: list = []
     failed: list = []
     loader.loaded.connect(lambda assets, description: loaded.append((assets, description)))
-    loader.failed.connect(failed.append)
+    # Same arity caveat as below: this branch should never fire, and under PySide6 a
+    # builtin slot would fail *silently* if it ever did.
+    loader.failed.connect(lambda item, request_id: failed.append(item))
     try:
         loader.load(SceneSource(path=path, kind="package", directory=path.parent))
         assert _pump(qt_app, lambda: bool(loaded or failed)), "the loader never answered"
@@ -679,7 +681,10 @@ def test_a_corrupt_package_is_reported_not_raised(qt_app, tmp_path):
     broken.write_bytes(b"not a zip archive at all")
     loader = SceneAssetLoader()
     failed: list = []
-    loader.failed.connect(failed.append)
+    # ``failed`` carries (diagnostic, request id). PySide6 adapts to a *Python* callable's
+    # arity but not to a builtin's, so ``failed.append`` raises TypeError inside the emit,
+    # Qt swallows it, and the failure signal looks like it was never sent.
+    loader.failed.connect(lambda item, request_id: failed.append(item))
     try:
         loader.load(SceneSource(path=broken, kind="package", directory=tmp_path))
         assert _pump(qt_app, lambda: bool(failed)), "a corrupt package produced no answer"